linux-kernel - Re: [PATCH] fbdev: via: remove possibly unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <2570388.yn7rRtV55D@amdc3058>
Date:   Wed, 14 Jun 2017 12:19:38 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Florian Tobias Schandinat <FlorianSchandinat@....de>,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbdev: via: remove possibly unused variables

On Tuesday, May 16, 2017 01:28:57 PM Arnd Bergmann wrote:
> When CONFIG_PROC_FS is disabled, we get warnings about unused variables
> as remove_proc_entry() evaluates to an empty macro.
> 
> drivers/video/fbdev/via/viafbdev.c: In function 'viafb_remove_proc':
> drivers/video/fbdev/via/viafbdev.c:1635:4: error: unused variable 'iga2_entry' [-Werror=unused-variable]
> drivers/video/fbdev/via/viafbdev.c:1634:4: error: unused variable 'iga1_entry' [-Werror=unused-variable]
> 
> These are easy to avoid by using the pointer from the structure.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics