linux-kernel - Re: [PATCH] tee: add forward declaration for struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1--+tTbe3TXLjdBP2e85_3294_MTDUy2Y5ceQ7eOOHnQ@mail.gmail.com>
Date:   Wed, 14 Jun 2017 13:59:43 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Jerome Forissier <jerome.forissier@...aro.org>
Cc:     Jens Wiklander <jens.wiklander@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        tee-dev@...ts.linaro.org
Subject: Re: [PATCH] tee: add forward declaration for struct device

On Wed, Jun 14, 2017 at 1:06 PM, Jerome Forissier
<jerome.forissier@...aro.org> wrote:
> On 06/14/2017 01:01 PM, Arnd Bergmann wrote:
>> On Wed, Jun 14, 2017 at 11:46 AM, Jens Wiklander
>> <jens.wiklander@...aro.org> wrote:
>>> On Wed, Jun 14, 2017 at 11:39:50AM +0200, Jerome Forissier wrote:
>>>> [+Arnd]
>>>>
>>>> Ping?
>>>>
>>>> Thanks,
>>>> --
>>>> Jerome
>>>>
>>>> On 05/31/2017 01:21 PM, Jerome Forissier wrote:
>>>>> tee_drv.h references struct device, but does not include device.h nor
>>>>> platform_device.h. Therefore, if tee_drv.h is included by some file
>>>>> that does not pull device.h nor platform_device.h beforehand, we have a
>>>>> compile warning. Fix this by adding a forward declaration.
>>>>>
>>>>> Signed-off-by: Jerome Forissier <jerome.forissier@...aro.org>
>>
>> Acked-by: Arnd Bergmann <arnd@...db.de>
>>
>> Do we need this to fix a warning in mainline, in linux-next, or only
>> in combination with some other patches?
>
> Only with some other patches.

Ok, in that case, Jens can just queue up the patch in his tree now,
and it will be there in time when other patches get applied on top,
no need to have this in arm-soc by itself.

Thanks,

        Arnd