linux-kernel - Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 15:20:13 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira
<Luis.Oliveira@...opsys.com> wrote:
> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
> - Slave functions added to core library file
> - Slave abort sources added to common source file
> - New driver: i2c-designware-slave added
> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>   when supported by the architecture.
>
> All the SLAVE flow is added but it is not enabled via platform
> driver.

> +       //~ if (stat & DW_IC_INTR_TX_OVER)
> +               //~ dw_readl(dev, DW_IC_CLR_TX_OVER);

If you are going to ignore reviewers' comments you will delay your
work to be applied.

Certainly you are about to miss v4.13.

-- 
With Best Regards,
Andy Shevchenko