linux-kernel - Re: [PATCH v2 1/8] tty: add a poll() callback in struct tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170614143300.5f2ebe4c@alans-desktop>
Date:   Wed, 14 Jun 2017 14:33:00 +0100
From:   Alan Cox <gnomes@...rguk.ukuu.org.uk>
To:     Tal Shorer <tal.shorer@...il.com>
Cc:     linux-doc@...r.kernel.org,
        "<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        "<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v2 1/8] tty: add a poll() callback in struct
 tty_operations

> That would cut it, but TIOCPKT is too coupled with having a linked tty.
> I could make acm behave like a pty (accept TIOCPKT and issue the
> ctrl_status bits), but for that I need n_tty to know that packet does
> not always mean a linked tty is present, and that in case it isn't we
> take our own ctrl_status bits instead of the link's. I could write a
> small (inline?) function to fetch the correct ctrl_status bits and put
> that in n_tty. Does that make sense?

I think that makes sense, and I would do the job properly rather than do
a hack with tty->link. Those hacks in the long term never work out the
best approach.

Alan