linux-kernel - Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170614111217.46825d2caf31eae9edb72162@kernel.org>
Date:   Wed, 14 Jun 2017 11:12:17 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kselftest@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest

Hi Shuah and Steve,

Sorry for replying so late...

On Thu, 8 Jun 2017 17:51:44 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Thu, 8 Jun 2017 15:44:08 -0600
> Shuah Khan <shuahkh@....samsung.com> wrote:
> 
> > > Also, did you see my reply about having the right config? You have
> > > HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in
> > > your report.  
> > 
> > I did see that one. Didn't get a chance to look at that yet. Do you expect
> > the tests to be skipped in this case? Could it be that tests aren't run?
> > I will look at this and let you know what I find on my test system.
> 
> Your first email showed that they passed, which would be hard to do
> since the feature is not even enabled. ftracetest is very much set up
> to look at the existing pseudo files to determine if a feature exists
> or not, and if it does not, it returns "UNSUPPORTED". If it returned
> PASSED when the feature is not enabled, that would be a big time bug in
> the test.

As far as I can see, what Steve you saw was my result on the 4.9 stable
kernel, which had been compiled with fully ftrace enabled :).

> > 
> > > 
> > > One more thing, is this 100% reproducible. That is, does it always fail?
> > >   
> > Failed the two times I tried.

I've also tried to test the latest linus tree with this series with Shuah's
config on qemu, and could not reproduced it. (I attached the log)
As you can see, with Shuah's config, histogram tests are marked UNSUPPORTED.

Of course, that is 4.12.0-rc5+ and kconfig is a bit tweaked(attached).
I'll try kselftest tree too.

Thank you,

> 
> Great to hear. I like reproducibility :-)
> 
> -- Steve
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>

View attachment "ftracetest.log" of type "text/plain" (2824 bytes)

Download attachment "mhiramat.config" of type "application/octet-stream" (186130 bytes)