linux-kernel - Re: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170614021950.GH23384@lunn.ch>
Date:   Wed, 14 Jun 2017 04:19:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     davem@...emloft.net, yisen.zhuang@...wei.com,
        huangdaode@...ilicon.com, lipeng321@...wei.com,
        mehta.salil.lnk@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH V2 net-next 7/8] net: hns3: Add Ethtool support to HNS3
 driver

> +	switch (media_type) {
> +	case HNAE3_MEDIA_TYPE_FIBER:
> +		cmd->base.port = PORT_FIBRE;
> +		supported_caps = HNS3_LM_FIBRE_BIT | HNS3_LM_AUTONEG_BIT |
> +			HNS3_LM_PAUSE_BIT | HNS3_LM_40000BASELR4_FULL_BIT |
> +			HNS3_LM_10000BASEKR_FULL_BIT |
> +			HNS3_LM_1000BASET_FULL_BIT;
> +		/* TODO: add speed 100G/50G/25G when ethtool and linux kernel
> +		 * is ready to support.

Linux already has:

linux/ethtool.h:	ETHTOOL_LINK_MODE_25000baseCR_Full_BIT	= 31,
linux/ethtool.h:	ETHTOOL_LINK_MODE_25000baseKR_Full_BIT	= 32,
linux/ethtool.h:	ETHTOOL_LINK_MODE_25000baseSR_Full_BIT	= 33,
linux/ethtool.h:	ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT	= 34,
linux/ethtool.h:	ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT	= 35,
linux/ethtool.h:	ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT  = 36,
linux/ethtool.h:	ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT  = 37,
linux/ethtool.h:	ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT  = 38,
linux/ethtool.h:	ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT	= 39,

	Andrew