linux-kernel - Re: [PATCH v3 2/4] xen: add sysfs node for guest type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a885e094-9403-7cda-5496-78e3a7273c6b@oracle.com>
Date:   Wed, 14 Jun 2017 11:01:17 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        xen-devel@...ts.xenproject.org
Cc:     gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 2/4] xen: add sysfs node for guest type

On 06/14/2017 11:00 AM, Juergen Gross wrote:
> On 14/06/17 16:48, Boris Ostrovsky wrote:
>>> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
>>> index 84106f9c456c..d641e9970d5d 100644
>>> --- a/drivers/xen/sys-hypervisor.c
>>> +++ b/drivers/xen/sys-hypervisor.c
>>> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void)
>>>  	return sysfs_create_file(hypervisor_kobj, &type_attr.attr);
>>>  }
>>>  
>>> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
>>> +{
>>> +	return sprintf(buffer, "%s\n", xen_guest_type);
>>> +}
>>
>> So I know I gave my R-b for this patch but can't we just key off
>> xen_domain_type and not have xen_guest_type at all?
> So we'd need to introduce XEN_PVH_DOMAIN and adjust xen_hvm_domain().

Can't we use xen_pvh_domain()?

-boris