linux-kernel - Re: [PATCH] ubifs : fix oops when remounting with no_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7852fe56-7193-f767-8aa7-6691a531087a@nod.at>
Date:   Wed, 14 Jun 2017 18:00:20 +0200
From:   Richard Weinberger <richard@....at>
To:     karam.lee@....com, Artem Bityutskiy <dedekind1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     "seungho.park" <seungho1.park@....com>
Subject: Re: [PATCH] ubifs : fix oops when remounting with no_bulk_read.

karam.lee,

Am 12.06.2017 um 03:46 schrieb karam.lee@....com:
> From: "karam.lee" <karam.lee@....com>
> 
> When remounting with the no_bulk_read option,
> there is a problem accessing the "bulk_read buffer(bu.buf)"
> which has already been freed.
> 
> If the bulk_read option is enabled,
> ubifs_tnc_bulk_read uses the pre-allocated bu.buf.
> 
> While bu.buf is being used by ubifs_tnc_bulk_read,
> remounting with no_bulk_read frees bu.buf.
> 
> So I added code to check the use of "bu.buf" to avoid this situation.

Agreed. We need to lock the buffer in this situation.
Thanks for fixing this.

Thanks,
//richard