linux-kernel - Re: [PATCH v3 14/18] xen/pvcalls: disconnect and module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1706141215250.12156@sstabellini-ThinkPad-X260>
Date:   Wed, 14 Jun 2017 12:15:32 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
cc:     Stefano Stabellini <sstabellini@...nel.org>,
        Juergen Gross <jgross@...e.com>, xen-devel@...ts.xen.org,
        linux-kernel@...r.kernel.org,
        Stefano Stabellini <stefano@...reto.com>
Subject: Re: [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit

On Wed, 14 Jun 2017, Boris Ostrovsky wrote:
> >>>  static int backend_disconnect(struct xenbus_device *dev)
> >>>  {
> >>> +	struct pvcalls_fedata *priv;
> >>> +	struct sock_mapping *map, *n;
> >>> +	struct sockpass_mapping *mappass;
> >>> +	struct radix_tree_iter iter;
> >>> +	void **slot;
> >>> +
> >>> +
> >>> +	priv = dev_get_drvdata(&dev->dev);
> 
> Can you also rename priv to something else (like fedata)? And in other
> routines too.

Yes, done