linux-kernel - Re: [PATCH 08/18] spi: qup: Handle v1 dma completion differently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jun 2017 15:53:58 -0400
From:   Andy Gross <andy.gross@...aro.org>
To:     Sricharan R <sricharan@...eaurora.org>
Cc:     Varadarajan Narayanan <varada@...eaurora.org>, broonie@...nel.org,
        robh+dt@...nel.org, mark.rutland@....com, david.brown@...aro.org,
        linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org
Subject: Re: [PATCH 08/18] spi: qup: Handle v1 dma completion differently

On Wed, Jun 14, 2017 at 12:45:51PM +0530, Sricharan R wrote:
> Hi Varada,
> 
> On 6/14/2017 11:22 AM, Varadarajan Narayanan wrote:
> > Do not assign i/o completion callbacks while running
> > on v1 of QUP.
> > 
> > Signed-off-by: Varadarajan Narayanan <varada@...eaurora.org>
> > ---
> >  drivers/spi/spi-qup.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
> > index 7c22ee4..0f6a4c7 100644
> > --- a/drivers/spi/spi-qup.c
> > +++ b/drivers/spi/spi-qup.c
> > @@ -334,6 +334,7 @@ static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
> >  			  unsigned long timeout)
> >  {
> >  	struct spi_qup *qup = spi_master_get_devdata(master);
> > +	dma_async_tx_callback done = qup->qup_v1 ? NULL : spi_qup_dma_done;
> >  	int ret;
> >  
> >  	/* before issuing the descriptors, set the QUP to run */
> > @@ -346,7 +347,7 @@ static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
> >  
> >  	if (xfer->rx_buf) {
> >  		ret = spi_qup_prep_sg(master, xfer, DMA_DEV_TO_MEM,
> > -					spi_qup_dma_done, &qup->rxc);
> > +					done, &qup->rxc);
> >  		if (ret)
> >  			return ret;
> >  
> > @@ -355,7 +356,7 @@ static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
> >  
> >  	if (xfer->tx_buf) {
> >  		ret = spi_qup_prep_sg(master, xfer, DMA_MEM_TO_DEV,
> > -					spi_qup_dma_done, &qup->txc);
> > +					done, &qup->txc);
> >  		if (ret)
> >  			return ret;
> >  
> > 
> 
>  Not sure why we cannot use dma callback for V1 ?

V1 is for ADMA.  V2+ is BAM.  We only needed the callback for BAM


Regards,

Andy