linux-kernel - Re: [PATCH] power: supply: constify psy_tcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170614201245.amwprdmnq4vso2xh@earth>
Date:   Wed, 14 Jun 2017 22:12:46 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: constify psy_tcd_ops.

Hi,

On Tue, Jun 13, 2017 at 10:39:43AM +0530, Arvind Yadav wrote:
> File size before:
> text	data	bss	dec   hex filename
> 4240	 200	 80	4520 11a8 drivers/power/supply/power_supply_core.o
> 
> File size After adding 'const':
> text	data	bss	dec   hex filename
> 4296	 136	 80	4512 11a0 drivers/power/supply/power_supply_core.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks, queued.

-- Sebastian

> ---
>  drivers/power/supply/power_supply_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
> index 7ec7c7c..2cc64b8 100644
> --- a/drivers/power/supply/power_supply_core.c
> +++ b/drivers/power/supply/power_supply_core.c
> @@ -669,7 +669,7 @@ static int ps_set_cur_charge_cntl_limit(struct thermal_cooling_device *tcd,
>  	return ret;
>  }
>  
> -static struct thermal_cooling_device_ops psy_tcd_ops = {
> +static const struct thermal_cooling_device_ops psy_tcd_ops = {
>  	.get_max_state = ps_get_max_charge_cntl_limit,
>  	.get_cur_state = ps_get_cur_chrage_cntl_limit,
>  	.set_cur_state = ps_set_cur_charge_cntl_limit,
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)