linux-kernel - Re: [PATCH] dmaengine: pl330: Mark unused functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170614210551.GN141096@google.com>
Date:   Wed, 14 Jun 2017 14:05:51 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: Mark unused functions as __maybe_unused

El Wed, Jun 14, 2017 at 10:28:31AM +0530 Vinod Koul ha dit:

> On Fri, May 19, 2017 at 01:02:26PM -0700, Matthias Kaehlcke wrote:
> > Several functions are not used and probably kept around for completeness
> > or debugging. Adding the attribute fixes a bunch of warnings like this
> > when building with clang:
> > 
> > drivers/dma/pl330.c:568:19: error: unused function '_emit_ADDH'
> >     [-Werror,-Wunused-function]
> 
> Well I dont see these being used, so why should we keep the dead code.
> Can you please remove these

Ok, I'll send a patch with the removal shortly