linux-kernel - Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08a95adb-90af-1439-73be-4f992d433d1d@axentia.se>
Date:   Fri, 16 Jun 2017 00:40:08 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Peter Rosin <peda@...ator.liu.se>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

On 2017-06-15 11:37, Boris Brezillon wrote:
> On Thu, 15 Jun 2017 11:24:13 +0200
> Peter Rosin <peda@...ator.liu.se> wrote:
> 
>> From: Peter Rosin <peda@...ntia.se>
>>
>> Remove the layer.
> 
> Duh. It was present in the datasheet I had. Just downloaded last
> version of the datasheet and it's no longer there.

Heh.

> Nicolas, there's still a reference to OVR2 in the block diagram
> (Section "31.3 Block Diagram"), can ask fix that (or ask someone who
> can).

Also, on page 2 (the Features chapter under peripherals) there's:

   "LCD TFT Controller with 4 overlays..."

I think it should be three?

Cheers,
peda

>>
>> Fixes: 5b9fb5e6c6c7 ("drm: atmel-hlcdc: add support for sama5d4 SoCs")
>> Signed-off-by: Peter Rosin <peda@...ntia.se>
>> ---
>>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 20 +-------------------
>>  1 file changed, 1 insertion(+), 19 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> index 30dbffd..888524a 100644
>> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> @@ -295,28 +295,10 @@ static const struct atmel_hlcdc_layer_desc atmel_hlcdc_sama5d4_layers[] = {
>>  		},
>>  	},
>>  	{
>> -		.name = "overlay2",
>> -		.formats = &atmel_hlcdc_plane_rgb_formats,
>> -		.regs_offset = 0x240,
>> -		.id = 2,
>> -		.type = ATMEL_HLCDC_OVERLAY_LAYER,
>> -		.cfgs_offset = 0x2c,
>> -		.layout = {
>> -			.pos = 2,
>> -			.size = 3,
>> -			.xstride = { 4 },
>> -			.pstride = { 5 },
>> -			.default_color = 6,
>> -			.chroma_key = 7,
>> -			.chroma_key_mask = 8,
>> -			.general_config = 9,
>> -		},
>> -	},
>> -	{
>>  		.name = "high-end-overlay",
>>  		.formats = &atmel_hlcdc_plane_rgb_and_yuv_formats,
>>  		.regs_offset = 0x340,
>> -		.id = 3,
>> +		.id = 2,
>>  		.type = ATMEL_HLCDC_OVERLAY_LAYER,
>>  		.cfgs_offset = 0x4c,
>>  		.layout = {
>