linux-kernel - Re: [PATCH] USB: gtco: remove unnecessary variable assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497502848.14396.2.camel@perches.com>
Date:   Wed, 14 Jun 2017 22:00:48 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: gtco: remove unnecessary variable assignments

On Wed, 2017-06-14 at 20:50 -0500, Gustavo A. R. Silva wrote:
> Remove unnecessary variable assignments.
> Variable _val_ is overwritten before the value stored in it can be used.
> 
> Addresses-Coverity-ID: 1397695
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/input/tablet/gtco.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
> index b796e89..d9de13c 100644
> --- a/drivers/input/tablet/gtco.c
> +++ b/drivers/input/tablet/gtco.c
> @@ -652,8 +652,6 @@ static void gtco_urb_callback(struct urb *urbinfo)
>  		switch (device->buffer[0]) {
>  		case 5:
>  			/* Pressure is 9 bits */
> -			val = ((u16)(device->buffer[8]) << 1);
> -			val |= (u16)(device->buffer[7] >> 7);
>  			input_report_abs(inputdev, ABS_PRESSURE,
>  					 device->buffer[8]);

Perhaps more likely to be

			input_report_abs(inputdev, ABS_PRESSURE, val);