linux-kernel - RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <KAWPR01MB1092CFFDF4C4490669DCE92CC7C00@KAWPR01MB1092.jpnprd01.prod.outlook.com>
Date:   Thu, 15 Jun 2017 00:33:29 +0000
From:   Masaki Ota <masaki.ota@...alps.com>
To:     Laura Abbott <labbott@...hat.com>,
        Paul Donohue <linux-kernel@...lSD.com>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Pali Rohar <pali.rohar@...il.com>,
        Nick Fletcher <nick.m.fletcher@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "scott.s.lowe@...il.com" <scott.s.lowe@...il.com>
Subject: RE: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS -
 fix V8+ protocol handling (73 03 28)")

Hi, Paul, Dmitry,

About Laura's test result, it seems like this issue has to do with x_max, y_max, x_res, y_res.
This values are set as following code.
	input_set_abs_params(dev1, ABS_MT_POSITION_X, 0, priv->x_max, 0, 0);
	input_set_abs_params(dev1, ABS_MT_POSITION_Y, 0, priv->y_max, 0, 0);

	input_abs_set_res(dev1, ABS_MT_POSITION_X, priv->x_res);
	input_abs_set_res(dev1, ABS_MT_POSITION_Y, priv->y_res);

For testing this code, I assigned an abnormal value to x_max, y_max , and it seems to effect only cursor speed.
About x_res, y_res , there is no effect, even if I set an abnormal value.(need this code?)
I don't understand why these values have to do with this issue.

Can you guess the root cause of this issue?

Best Regards,
Masaki Ota
-----Original Message-----
From: Laura Abbott [mailto:labbott@...hat.com] 
Sent: Thursday, June 15, 2017 3:53 AM
To: 太田 真喜 Masaki Ota <masaki.ota@...alps.com>; Paul Donohue <linux-kernel@...lSD.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>; Pali Rohar <pali.rohar@...il.com>; Nick Fletcher <nick.m.fletcher@...il.com>; linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; scott.s.lowe@...il.com
Subject: Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

On 06/11/2017 10:25 PM, Masaki Ota wrote:
> Hi, Laura,
> 
> Could you try to check below modification?
> https://bugzilla.kernel.org/show_bug.cgi?id=195215#c10
> 
> This thread person said, the issue was fixed by this change.
> I guess it's a XY coordinate setting problem, though the code that before the patch is applied also has a problem.
> 

With the previous patch plus the part you suggested:

"it appears as if this resolves all remaining touchpad issues.
Cursor movement works as expected, both on the left-hand and right-hand sides of the touchpad, and I did not see any issues with two-finger scrolling on either side of the touchpad. Behavior with this test build appeared to be identical to 4.10.5, the last "official" kernel release to work with my touchpad."

So it sounds like both parts together fix the issue.

Thanks,
Laura

> Best Regards,
> Masaki Ota
> -----Original Message-----
> From: Laura Abbott [mailto:labbott@...hat.com]
> Sent: Wednesday, June 07, 2017 1:59 AM
> To: Paul Donohue <linux-kernel@...lSD.com>
> Cc: 太田 真喜 Masaki Ota <masaki.ota@...alps.com>; Dmitry Torokhov 
> <dmitry.torokhov@...il.com>; Pali Rohar <pali.rohar@...il.com>; Nick 
> Fletcher <nick.m.fletcher@...il.com>; linux-input@...r.kernel.org; 
> linux-kernel@...r.kernel.org; scott.s.lowe@...il.com
> Subject: Re: [REGRESSION] Touchpad failure after e7348396c6d5 ("Input: 
> ALPS - fix V8+ protocol handling (73 03 28)")
> 
> On 06/02/2017 09:03 PM, Paul Donohue wrote:
>> This might be related to
>> https://bugzilla.kernel.org/show_bug.cgi?id=195215
>>
>> Could you have the user try this change? 
>> https://bugzilla.kernel.org/show_bug.cgi?id=195215#c12
>>
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1447327#c13
> 
> "Cursor movement seems to work, but there are intermittent two-finger scrolling issues on the right-hand side of the touchpad. There are no issues with cursor movement or two-finger scrolling on the left-hand side of the touchpad."
> 
>> On Fri, Jun 02, 2017 at 10:54:52AM -0700, Laura Abbott wrote:
>>> Hi,
>>>
>>> Fedora got a bug report
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1447327
>>> of a touchpad failure on a Dell Latitude E7370. Testing showed that 
>>> the bad commit was
>>>
>>> commit e7348396c6d51b57c95c6646c390cd078e038e19
>>> Author: Masaki Ota <masaki.ota@...alps.com>
>>> Date:   Fri Mar 17 14:10:57 2017 -0700
>>>
>>>     Input: ALPS - fix V8+ protocol handling (73 03 28)
>>>     
>>>     Devices identified as E7="73 03 28" use slightly modified version of V8
>>>     protocol, with lower count per electrode, different offsets, and different
>>>     feature bits in OTP data.
>>>     
>>>     Fixes: aeaa881f9b17 ("Input: ALPS - set DualPoint flag for 74 03 28 devices")
>>>     Signed-off-by: Masaki Ota <masaki.ota@...alps.com>
>>>     Acked-by: Pali Rohar <pali.rohar@...il.com>
>>>     Tested-by: Paul Donohue <linux-kernel@...lSD.com>
>>>     Tested-by: Nick Fletcher <nick.m.fletcher@...il.com>
>>>     Cc: stable@...r.kernel.org
>>>     Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>>
>>> I suspect this particular model needs special handling as well?
>>>
>>> Thanks,
>>> Laura
>>>
>