linux-kernel - Re: [patch 1/2] staging: speakup: add function to convert dev name to number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtcWM1MfnpGW+ZxnfkXUvMX5caPQtBHbOws1qk17ROqXoCQhQ@mail.gmail.com>
Date:   Thu, 15 Jun 2017 09:17:12 +0100
From:   Okash Khawaja <okash.khawaja@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Kirk Reiser <kirk@...sers.ca>,
        "Speakup is a screen review system for Linux." 
        <speakup@...ux-speakup.org>, Chris Brannon <chris@...-brannons.com>
Subject: Re: [patch 1/2] staging: speakup: add function to convert dev name to number

Hi,

On Wed, Jun 14, 2017 at 9:23 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
[...]
>
> Could you call it "dev_name" instead?  I normally expect "dev" to be a
> device struct.

Thanks for the feedback. Will keep these in mind for next version of the patch.

Okash