linux-kernel - RE: [PATCH] staging: fsl-mc/dpio: Propagate error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB5PR04MB12401B2E39BC94F7DAD4B49CEAC00@DB5PR04MB1240.eurprd04.prod.outlook.com>
Date:   Thu, 15 Jun 2017 08:58:10 +0000
From:   Bogdan Purcareata <bogdan.purcareata@....com>
To:     Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>, "arnd@...db.de" <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "stuyoder@...il.com" <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        "Ruxandra Ioana Radulescu" <ruxandra.radulescu@....com>,
        Roy Pledge <roy.pledge@....com>,
        Haiying Wang <haiying.wang@....com>
Subject: RE: [PATCH] staging: fsl-mc/dpio: Propagate error code

> -----Original Message-----
> From: Ioana Radulescu [mailto:ruxandra.radulescu@....com]
> Sent: Thursday, June 15, 2017 11:55 AM
> To: gregkh@...uxfoundation.org
> Cc: devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org;
> agraf@...e.de; arnd@...db.de; linux-arm-kernel@...ts.infradead.org; Bogdan
> Purcareata <bogdan.purcareata@....com>; stuyoder@...il.com; Laurentiu Tudor
> <laurentiu.tudor@....com>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@....com>; Roy Pledge <roy.pledge@....com>; Haiying Wang
> <haiying.wang@....com>
> Subject: [PATCH] staging: fsl-mc/dpio: Propagate error code
> 
> dpaa2_io_service_register() returns zero even if
> qbman_swp_CDAN_set() encountered an error. Fix this
> by propagating the error code so the caller is informed
> data availability notifications are not properly set
> for a channel.
> 
> Signed-off-by: Ioana Radulescu <ruxandra.radulescu@....com>

Acked-by: Bogdan Purcareata <bogdan.purcareata@....com>

> ---
>  drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> index e5d66749614c..762f045f53f7 100644
> --- a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> +++ b/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
> @@ -260,9 +260,9 @@ int dpaa2_io_service_register(struct dpaa2_io *d,
> 
>  	/* Enable the generation of CDAN notifications */
>  	if (ctx->is_cdan)
> -		qbman_swp_CDAN_set_context_enable(d->swp,
> -						  (u16)ctx->id,
> -						  ctx->qman64);
> +		return qbman_swp_CDAN_set_context_enable(d->swp,
> +							 (u16)ctx->id,
> +							 ctx->qman64);
>  	return 0;
>  }
>  EXPORT_SYMBOL(dpaa2_io_service_register);
> --
> 2.11.0