linux-kernel - Re: [PATCH] cpufreq: sfi: make freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170615095843.GA3942@vireshk-i7>
Date:   Thu, 15 Jun 2017 15:28:43 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: sfi: make freq_table static

On 15-06-17, 10:55, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> pointer freq_table can be made static as it does not need to be in
> global scope.
> 
> Cleans up sparse warning:
> "symbol 'freq_table' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/cpufreq/sfi-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c
> index 992ce6f9abec..3779742f86e3 100644
> --- a/drivers/cpufreq/sfi-cpufreq.c
> +++ b/drivers/cpufreq/sfi-cpufreq.c
> @@ -24,7 +24,7 @@
>  
>  #include <asm/msr.h>
>  
> -struct cpufreq_frequency_table *freq_table;
> +static struct cpufreq_frequency_table *freq_table;
>  static struct sfi_freq_table_entry *sfi_cpufreq_array;
>  static int num_freq_table_entries;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh