linux-kernel - Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function cnl_ddi_dp_set_dpll_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2017 16:16:03 +0300
From:   Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:     Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>
Cc:     Colin King <colin.king@...onical.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Intel-gfx] [PATCH][drm-next] drm/i915/cnl: make function
 cnl_ddi_dp_set_dpll_hw_state static

On Wed, Jun 14, 2017 at 02:03:05PM +0100, Tvrtko Ursulin wrote:
> 
> On 13/06/2017 14:47, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The function cnl_ddi_dp_set_dpll_hw_state does not need to be in global
> > scope, so make it static.
> > 
> > Cleans up sparse warning:
> > "symbol 'cnl_ddi_dp_set_dpll_hw_state' was not declared. Should it
> >   be static?"
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >   drivers/gpu/drm/i915/intel_dpll_mgr.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > index 8e669b6254ae..2f7b0e64f628 100644
> > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> > @@ -2292,8 +2292,9 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
> >   	return true;
> >   }
> >   
> > -bool cnl_ddi_dp_set_dpll_hw_state(int clock,
> > -				  struct intel_dpll_hw_state *dpll_hw_state)
> > +static bool
> > +cnl_ddi_dp_set_dpll_hw_state(int clock,
> > +			     struct intel_dpll_hw_state *dpll_hw_state)
> >   {
> >   	uint32_t cfgcr0;
> >   
> > 
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...el.com>

Thanks for the patch and review. Pushed to dinq.

-- 
Ville Syrjälä
Intel OTC