linux-kernel - Re: [PATCH] watchdog: bcm47xx_wdt: constify bcm47xx_wdt_hard_ops and bcm47xx_wdt_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170615172559.GB7549@roeck-us.net>
Date:   Thu, 15 Jun 2017 10:25:59 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     wim@...ana.be, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: bcm47xx_wdt: constify bcm47xx_wdt_hard_ops and
 bcm47xx_wdt_soft_ops

On Mon, Jun 12, 2017 at 11:50:26AM +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    1282	    388	      1	   1671	    687	drivers/watchdog/bcm47xx_wdt.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    1474	    196	      1	   1671	    687	drivers/watchdog/bcm47xx_wdt.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/bcm47xx_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/bcm47xx_wdt.c b/drivers/watchdog/bcm47xx_wdt.c
> index 35725e2..2365828 100644
> --- a/drivers/watchdog/bcm47xx_wdt.c
> +++ b/drivers/watchdog/bcm47xx_wdt.c
> @@ -97,7 +97,7 @@ static int bcm47xx_wdt_restart(struct watchdog_device *wdd,
>  	return 0;
>  }
>  
> -static struct watchdog_ops bcm47xx_wdt_hard_ops = {
> +static const struct watchdog_ops bcm47xx_wdt_hard_ops = {
>  	.owner		= THIS_MODULE,
>  	.start		= bcm47xx_wdt_hard_start,
>  	.stop		= bcm47xx_wdt_hard_stop,
> @@ -168,7 +168,7 @@ static int bcm47xx_wdt_soft_set_timeout(struct watchdog_device *wdd,
>  				WDIOF_MAGICCLOSE,
>  };
>  
> -static struct watchdog_ops bcm47xx_wdt_soft_ops = {
> +static const struct watchdog_ops bcm47xx_wdt_soft_ops = {
>  	.owner		= THIS_MODULE,
>  	.start		= bcm47xx_wdt_soft_start,
>  	.stop		= bcm47xx_wdt_soft_stop,
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html