[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170615184928.12007-4-javier@dowhile0.org>
Date: Thu, 15 Jun 2017 20:49:23 +0200
From: Javier Martinez Canillas <javier@...hile0.org>
To: linux-kernel@...r.kernel.org
Cc: devicetree@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
Rob Herring <robh+dt@...nel.org>,
Tony Lindgren <tony@...mide.com>,
Lee Jones <lee.jones@...aro.org>,
Aaro Koskinen <aaro.koskinen@....fi>,
Javier Martinez Canillas <javier@...hile0.org>
Subject: [RESEND PATCH v6 3/8] mfd: retu: Add OF device ID table
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have a
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@...hile0.org>
Acked-by: Rob Herring <robh@...nel.org>
Acked-by: Aaro Koskinen <aaro.koskinen@....fi>
Acked-by: Tony Lindgren <tony@...mide.com>
Acked-by: Lee Jones <lee.jones@...aro.org>
Reviewed-by: Wolfram Sang <wsa@...-dreams.de>
---
Changes in v6:
- Add Wolfram Sang's Reviewed-by tag.
Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@...mide.com>'s Acked-by tag.
- Add Lee Jones <lee.jones@...aro.org>'s Acked-by tag.
Changes in v4:
- Drop -mfd suffix in compatible string (Lee Jones).
Changes in v3:
- Add a vendor prefix to the compatible string (Rob Herring).
Changes in v2:
- Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
drivers/mfd/retu-mfd.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
index 53e1d386d2c0..e7d27b7861c1 100644
--- a/drivers/mfd/retu-mfd.c
+++ b/drivers/mfd/retu-mfd.c
@@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
};
MODULE_DEVICE_TABLE(i2c, retu_id);
+static const struct of_device_id retu_of_match[] = {
+ { .compatible = "nokia,retu" },
+ { .compatible = "nokia,tahvo" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, retu_of_match);
+
static struct i2c_driver retu_driver = {
.driver = {
.name = "retu-mfd",
+ .of_match_table = retu_of_match,
},
.probe = retu_probe,
.remove = retu_remove,
--
2.9.3
Powered by blists - more mailing lists