linux-kernel - Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170615160740.Horde.Jp_M9DTPyKHhri-Ff7J7hSX@gator4166.hostgator.com>
Date:   Thu, 15 Jun 2017 16:07:40 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] intel: i40e: virtchnl: fix incorrect
 variable assignment

Hi Jesse,

Quoting Jesse Brandeburg <jesse.brandeburg@...el.com>:

> On Wed, 14 Jun 2017 21:38:26 -0500
> "Gustavo A. R. Silva" <garsilva@...eddedor.com> wrote:
>
>> Fix incorrect variable assignment.
>> Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be
>> used in this instance is aq_ret instead of ret. Also, variable ret is
>> updated at line 1602 just before return, so assigning a value to this
>> variable in this code block is useless.
>>
>> Addresses-Coverity-ID: 1397693
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
> Thanks for the fix, looks reasonable.
> Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

Absolutely, glad to help.

Regards
--
Gustavo A. R. Silva