linux-kernel - Re: [PATCH] serial: Delete dead code for CIR serial ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497613434.22624.145.camel@linux.intel.com>
Date:   Fri, 16 Jun 2017 14:43:54 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Matthias Brugger <mbrugger@...e.com>, gregkh@...uxfoundation.org,
        jslaby@...e.com
Cc:     ed.blake@...tec.com, vigneshr@...com, alexander.sverdlin@...ia.com,
        yegorslists@...glemail.com, dhowells@...hat.com,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: Delete dead code for CIR serial ports

On Thu, 2017-06-15 at 17:54 +0200, Matthias Brugger wrote:
> Commit e4fda3a04275 ("serial: don't register CIR serial ports") adds a
> check for PORT_8250_CIR to serial8250_register_8250_port(). But the
> code
> isn't needed as the function never takes the branch when the port is
> CIR
> serial port.

> +		if (serial8250_isa_config != NULL)

> +			serial8250_isa_config(0, &uart->port,
> +					&uart->capabilities);

Can't it be one line after all?

>  

> +		ret = uart_add_one_port(&serial8250_reg,
> +					&uart->port);

Ditto.

> +		if (ret == 0)
> +			ret = uart->port.line;

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy