linux-kernel - Re: [PATCH v2 11/11] kasan: rework Kconfig settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+ZGbvy5jK=ouHxgcSKkCdvJBM6=4Gkd1sGvzOZvKg79GQ@mail.gmail.com>
Date:   Fri, 16 Jun 2017 13:44:50 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <mmarek@...e.com>,
        Kees Cook <keescook@...omium.org>,
        Ingo Molnar <mingo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "open list:KERNEL BUILD + fi..." <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2 11/11] kasan: rework Kconfig settings

On Fri, Jun 16, 2017 at 1:42 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>> diff --git a/lib/Kconfig.kmemcheck b/lib/Kconfig.kmemcheck
>>> index 846e039a86b4..58b9f3f81dc8 100644
>>> --- a/lib/Kconfig.kmemcheck
>>> +++ b/lib/Kconfig.kmemcheck
>>> @@ -7,6 +7,7 @@ menuconfig KMEMCHECK
>>>         bool "kmemcheck: trap use of uninitialized memory"
>>>         depends on DEBUG_KERNEL
>>>         depends on !X86_USE_3DNOW
>>> +       depends on !KASAN_EXTRA
>>
>>
>> KASAN is not meant to work with KMEMCHECK. I am not sure if it even
>> works, and it's definitely unmaintained. Even if it works now, I am
>> not sure what could be the intention of somebody running that
>> combination.
>> So I think we should do: depends on !KASAN
>> Will it make things simper for you?
>
> I don't think it will change anything for me, other than having to respin the
> patch series or adding a patch on top.
>
> I have just checked that KMEMCHECK is already disabled in allmodconfig,
> and all but one of the warnings I address in the series show up in
> allmodconfig too.

Ack.

We can disable it if/when KASAN+KMEMCHECK combination requires any
additional work, or causes user confusion.