linux-kernel - Re: [PATCH] block: swim3: make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170616114830.GB25147@linux-x5ow.site>
Date:   Fri, 16 Jun 2017 13:48:30 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     jthumshirn@...e.de, axboe@...com, mingo@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: swim3: make of_device_ids const.

On Fri, Jun 16, 2017 at 03:24:39PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    8908	   1096	    624	  10628	   2984	drivers/block/swim3.o
> 
> File size after constify swim3_match:
>    text	   data	    bss	    dec	    hex	filename
>    9708	    296	    624	  10628	   2984	drivers/block/swim3.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---


Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850