linux-kernel - Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170616020218.GC465@jagdpanzerIV.localdomain>
Date:   Fri, 16 Jun 2017 11:02:18 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Aleksey Makarov <aleksey.makarov@...aro.org>,
        Sabrina Dubroca <sd@...asysnail.net>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] printk/console: Clean up logic around fallback
 console

On (06/15/17 17:31), Petr Mladek wrote:
[..]
> > diff --git a/include/linux/console.h b/include/linux/console.h
> > index b8920a031a3e..a2525e0d7605 100644
> > --- a/include/linux/console.h
> > +++ b/include/linux/console.h
> > @@ -127,7 +127,7 @@ static inline int con_debug_leave(void)
> >   */
> >  
> >  #define CON_PRINTBUFFER        (1)
> > -#define CON_CONSDEV    (2) /* Last on the command line */
> > +#define CON_CONSDEV    (2)
> 
> The description is wrong. The name and the use suggest that
> it should be something like:
> 
> #define CON_CONSDEV    (2) /* Driver used by /dev/console */

that's better, indeed.

> There are some situations (bugs) where this is not true.

true.

	-ss