linux-kernel - Re: [PATCH] kbuild: fix header installation under fakechroot environment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ+3PNmHiTzKEbOBkCsZt2Eq3CAY6sZ-CbF=X6sejVp7Q@mail.gmail.com>
Date:   Fri, 16 Jun 2017 11:20:34 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Richard Genoud <richard.genoud@...il.com>
Cc:     Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Mark Salter <msalter@...hat.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: fix header installation under fakechroot environment

Hi Richard,


2017-06-15 17:36 GMT+09:00 Richard Genoud <richard.genoud@...il.com>:
> Since commit fcc8487d477a ("uapi: export all headers under uapi
> directories") fakechroot make bindeb-pkg fails, mismatching files for
> directories:
> touch: cannot touch 'usr/include/video/uvesafb.h/.install': Not a
> directory
>
> This due to a bug in fakechroot:
> when using the function $(wildcard $(srcdir)/*/.) in a makefile, under a
> fakechroot environment, not only directories but also files are
> returned.
>
> To circumvent that, we are using the functions:
> $(sort $(dir $(wildcard $(srcdir)/*/))))
>
> And thanks to Yamada Masahiro who figured out the right
> filter-out/patsubst order !

Sorry if I confused you.

The order of filter-out/patsubst was not a real problem,
but just a matter of taste.

Your original code used $(filter-out ./, ...),
but this could not filter out anything.  This is the root cause.

I will remove this paragraph because it is even confusing.

Thanks for the credit, but it is regular review process,
so it is not mandatory in git-log.  :-)


I will pick up this patch shortly anyway.




-- 
Best Regards
Masahiro Yamada