linux-kernel - Re: [PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <2d6c7d4c-f2f5-495a-70c3-7768654ce8c7@samsung.com>
Date:   Fri, 16 Jun 2017 17:30:58 +0200
From:   Andrzej Pietrasiewicz <andrzej.p@...sung.com>
To:     Thierry Escande <thierry.escande@...labora.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for
 Exynos5420

Hi Thierry,

Thank you for the patch. Please see inline.

W dniu 12.06.2017 o 19:13, Thierry Escande pisze:
> From: henryhsu <henryhsu@...omium.org>
> 
> On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means
> there is a syntax error or an unrecoverable error on compressed file
> when ERR_INT_EN is set to 1.
> 
> Fix this case and report BUF_STATE_ERROR to videobuf2.
> 
> Signed-off-by: Henry-Ruey Hsu <henryhsu@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index 3d90a63..1a07a82 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2790,6 +2790,7 @@ static irqreturn_t exynos3250_jpeg_irq(int irq, void *dev_id)
>   	unsigned long payload_size = 0;
>   	enum vb2_buffer_state state = VB2_BUF_STATE_DONE;
>   	bool interrupt_timeout = false;
> +	bool stream_error = false;
>   	u32 irq_status;
>   
>   	spin_lock(&jpeg->slock);
> @@ -2806,6 +2807,11 @@ static irqreturn_t exynos3250_jpeg_irq(int irq, void *dev_id)
>   
>   	jpeg->irq_status |= irq_status;
>   
> +	if (irq_status & EXYNOS3250_STREAM_STAT) {

If the problem which is supposed to be fixed happens on 5420,
then why the 3250 variant is also affected by this patch?

Shouldn't jpeg->variant->version be checked and equal SJPEG_EXYNOS5420?

Andrzej