linux-kernel - Re: [PATCH v1 0/2] perf report: Implement visual marker for macro fusion in annotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170616161655.GG3645@kernel.org>
Date:   Fri, 16 Jun 2017 13:16:55 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 0/2] perf report: Implement visual marker for macro
 fusion in annotate

Em Wed, Jun 14, 2017 at 10:53:39AM +0800, Jin Yao escreveu:
> Macro fusion merges two instructions to a single micro-op. Intel
> core platform performs this hardware optimization under limited
> circumstances. For example, CMP + JCC can be "fused" and executed
> /retired together. While with sampling this can result in the
> sample sometimes being on the JCC and sometimes on the CMP.
> So for the fused instruction pair, they could be considered
> together.
> 
> In general, the fused instruction pairs are:
> 
> cmp/test/add/sub/and/inc/dec + jcc.
> 
> This patch series marks the case clearly by joining the fused
> instruction pair in the arrow of the jump.
> 
> For example:
> 
>        │   ┌──cmpl   $0x0,argp_program_version_hook
>  81.93 │   │──je     20
>        │   │  lock   cmpxchg %esi,0x38a9a4(%rip)
>        │   │↓ jne    29
>        │   │↓ jmp    43
>  11.47 │20:└─→cmpxch %esi,0x38a999(%rip)

Try to have these example outputs in the changesets, not just in the
patch series header.

- Arnaldo
 
> Jin Yao (2):
>   perf report: Check for fused instruction pair
>   perf report: Implement visual marker for macro fusion in annotate
> 
>  tools/perf/arch/x86/util/Build    |  1 +
>  tools/perf/arch/x86/util/fused.c  | 20 ++++++++++++++++++++
>  tools/perf/ui/browser.c           | 27 +++++++++++++++++++++++++++
>  tools/perf/ui/browser.h           |  2 ++
>  tools/perf/ui/browsers/annotate.c | 30 ++++++++++++++++++++++++++++++
>  tools/perf/util/Build             |  1 +
>  tools/perf/util/annotate.c        |  5 +++++
>  tools/perf/util/annotate.h        |  1 +
>  tools/perf/util/fused.c           | 11 +++++++++++
>  tools/perf/util/fused.h           |  8 ++++++++
>  10 files changed, 106 insertions(+)
>  create mode 100644 tools/perf/arch/x86/util/fused.c
>  create mode 100644 tools/perf/util/fused.c
>  create mode 100644 tools/perf/util/fused.h
> 
> -- 
> 2.7.4