linux-kernel - Re: [PATCH] MIPS: Make individual platforms select ARCH_MIGHT_HAVE_PC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1706162110010.23046@tp.orcam.me.uk>
Date:   Fri, 16 Jun 2017 21:18:56 +0100
From:   "Maciej W. Rozycki" <macro@...tec.com>
To:     Florian Fainelli <f.fainelli@...il.com>
CC:     <linux-mips@...ux-mips.org>, <msalter@...hat.com>,
        <dmitry.torokhov@...il.com>, Ralf Baechle <ralf@...ux-mips.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Make individual platforms select
 ARCH_MIGHT_HAVE_PC_SERIO

On Fri, 16 Jun 2017, Florian Fainelli wrote:

> >  How did you determine that?  Malta for one not only has an SMSC FDC37M817 
> > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 
> > keyboard and mouse connectors as well.
> 
> I was just grepping for i8042 in platform code to determine that, this
> came after having SERIO accidentally enabled on my platform
> (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap
> out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that
> don't need it.
> 
> Will come up with a v2 that includes malta, any other platforms for
> which it's not obvious?

 I don't know offhand, but in principle anything that has PCI and a 
southbridge (not all PCI platforms have one, e.g. Broadcom SWARM and 
BigSur are legacy-free) can have an 8042 wired.  Ideally probing for 8042 
hardware should be done by platform code and the driver's init code would 
not be called at all if there's no 8042 present, similarly to how e.g. RTC 
is usually registered.

  Maciej