linux-kernel - Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Jun 2017 16:45:49 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexander Gerasiov <gq@...lab-i.ru>
Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single
 parallel port card.

On Sat, Jun 17, 2017 at 4:02 PM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> From: Alexander Gerasiov <gq@...lab-i.ru>
>
> WCH CH382L is a PCI-E adapter with 1 parallel port. It is similair to CH382
> but serial ports are not soldered on board. Detected as
> Serial controller: Device 1c00:3050 (rev 10) (prog-if 05 [16850])

>         wch_ch382_2s1p,
> +       wch_ch382_0s1p,

>         /* wch_ch382_2s1p*/             { 1, { { 2, -1}, } },
> +       /* wch_ch382_0s1p*/             { 1, { { 2, -1}, } },

>         { 0x1c00, 0x3250, 0x1c00, 0x3250, 0, 0, wch_ch382_2s1p},
> +       { 0x1c00, 0x3050, 0x1c00, 0x3050, 0, 0, wch_ch382_0s1p},

Just a nit, wouldn't be better to preserve alphanumerical sorting?
(Exchange lines in above pairs)

> +       [wch_ch382_0s1p] = {
...
>         [sunix_2s1p] = {

Similar here, though it's not visible in the patch.

-- 
With Best Regards,
Andy Shevchenko