[<prev] [next>] [day] [month] [year] [list]
Message-ID: <s5h7f0anwfp.wl-tiwai@suse.de>
Date: Sat, 17 Jun 2017 23:20:10 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Hans Peter Möller <hmoller@...cl>
Cc: alsa-devel@...a-project.org, Stefan Hajnoczi <stefanha@...il.com>,
Andrej Kruták <dev@...ree.sk>,
linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] ALSA: line6: add support for POD HD500X
On Sat, 17 Jun 2017 21:03:40 +0200,
Hans Peter Möller wrote:
>
> My mistake, 2017, sorry. Should I generate again the 2 commits? or a third
> just correcting that? How should I handle it?
It's basically up to you. I can fix it in my side for such a trivial
thing, too, so no need for resend unless anyone else finds more
issue.
thanks,
Takashi
> brgds
> HPM
>
> On Sat, Jun 17, 2017 at 12:03 PM, Takashi Iwai <tiwai@...e.de> wrote:
>
> > On Fri, 16 Jun 2017 20:14:16 +0200,
> > Hans P. Möller Ebner wrote:
> > >
> > > Add support for the Line6 POD HD500X multi effect processor for playback
> > and capture (in/out audio) through USB.
> > >
> > > Signed-off-by: Hans P. Moller <hmoller@...cl>
> > > ---
> > > sound/usb/line6/podhd.c | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
> > > index 6ab23e5..e389f92 100644
> > > --- a/sound/usb/line6/podhd.c
> > > +++ b/sound/usb/line6/podhd.c
> > > @@ -3,6 +3,7 @@
> > > *
> > > * Copyright (C) 2011 Stefan Hajnoczi <stefanha@...il.com>
> > > * Copyright (C) 2015 Andrej Krutak <dev@...ree.sk>
> > > + * Copyright (C) 2015 Hans P. Moller <hmoller@...cl>
> >
> > Was the code written in two years ago? Otherwise put 2017.
> > (Or you can omit such a change, too. The change history can be
> > tracked via git nowadays.)
> >
> >
> > thanks,
> >
> > Takashi
> >
> [2 <text/html; UTF-8 (quoted-printable)>]
>
Powered by blists - more mailing lists