linux-kernel - Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Jun 2017 17:10:03 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     "Kani, Toshimitsu" <toshi.kani@....com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Verma, Vishal L" <vishal.l.verma@...el.com>,
        "Knippers, Linda" <linda.knippers@....com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

On Fri, Jun 16, 2017 at 5:01 PM, Kani, Toshimitsu <toshi.kani@....com> wrote:
>> > --- a/drivers/acpi/nfit/core.c
>> > +++ b/drivers/acpi/nfit/core.c
>> > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev,
>> >         if (nd_desc) {
>> >                 struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc);
>> >
>> > -               rc = acpi_nfit_ars_rescan(acpi_desc);
>> > +               rc = acpi_nfit_ars_rescan(acpi_desc, 0);
>> >         }
>> >         device_unlock(dev);
>> >         if (rc)
>> > @@ -2057,6 +2057,10 @@ static int ars_start(struct acpi_nfit_desc
>> *acpi_desc, struct nfit_spa *nfit_spa
>> >                 ars_start.type = ND_ARS_VOLATILE;
>> >         else
>> >                 return -ENOTTY;
>> > +       if (nfit_spa->ars_prev_data) {
>> > +               ars_start.flags |= ND_ARS_RETURN_PREV_DATA;
>> > +               nfit_spa->ars_prev_data = 0;
>> > +       }
>>
>> I'd rather you plumb a new 'flags' parameter all the way through from
>> acpi_nfit_ars_rescan() to ars_start() rather than carrying this as a
>> property of nfit_spa.
>
> Yes, I wanted to carry 'flags' all the way, but since acpi_nfit_ars_rescan()
> calls acpi_nfit_scrub() via acpi_desc->work, all info needs to be marshalled
> into struct acpi_nfit_desc.  Using nfit_spa allows a request to be carried as
> per-spa basis...

Ah ok, but I still think it does not belong to a spa. This is control
/ context information for the workqueue and that belongs with
acpi_nfit_desc. It think it's fine if all spas get re-scrubbed with
the "prev_data" flag in the the notification case.