linux-kernel - Re: [PATCH 2/2] sysfs: add devm_sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170617192704.GE2974@kroah.com>
Date:   Sat, 17 Jun 2017 21:27:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends

On Wed, Jun 07, 2017 at 10:04:45AM -0700, Dmitry Torokhov wrote:
> On Mon, Mar 27, 2017 at 09:35:45PM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Mar 27, 2017 at 10:53:59AM -0700, Dmitry Torokhov wrote:
> > > On Sun, Feb 12, 2017 at 04:36:19PM -0800, Dmitry Torokhov wrote:
> > > > Many drivers create additional driver-specific device attributes when
> > > > binding to the device and providing managed version of sysfs_create_group()
> > > > will simplify unbinding and error handling in probe path for such drivers.
> > > > 
> > > > Without managed version driver writers either have to mix manual and
> > > > managed resources, which is prone to errors, or open-code this function by
> > > > providing a wrapper to sysfs_create_group() and use it with
> > > > devm_add_action() or devm_add_action_or_reset().
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > > ---
> > > 
> > > Greg, gentle ping...
> > 
> > It's not lost, it's in my queue...
> 
> Another gentle ping...

Ugh, I've been hoping you would forget about this :)

But, in thinking a lot about this recently, I have now come to the same
conclusion as you, I think we really need this as there isn't a way to
handle it any other way.

So, can you rebase and resend these patches?  I don't have them in my
queue anymore and I'd like to play with them and see how they work.

thanks,

greg k-h