linux-kernel - Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170618130223.p2nysktwi3fqlvj2@ninjato>
Date:   Sun, 18 Jun 2017 15:02:23 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Hoan Tran <hotran@....com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Tin Huynh <tnhuynh@....com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap

On Thu, Jun 15, 2017 at 03:57:40PM +0200, Wolfram Sang wrote:
> On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote:
> > The newly added support for the pcc mailbox fails to build
> > in some configurations:
> > 
> > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
> > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in
> > 
> > This includes the missing header file.
> > 
> > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Applied to for-current, thanks!

Oops, the offending commit is only in for-next. So, reconsidered and
moved this patch to for-next as well.

Regards,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)