linux-kernel - Re: [PATCH 01/12] coresight replicator: Cleanup programmable replicator naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Jun 2017 09:04:41 -0500
From:   Rob Herring <robh@...nel.org>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Suzuki K Poulose <suzuki.poulose@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Pratik Patel <pratikp@...eaurora.org>,
        "Ivan T . Ivanov" <ivan.ivanov@...aro.org>,
        devicetree@...r.kernel.org, Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 01/12] coresight replicator: Cleanup programmable
 replicator naming

On Tue, Jun 13, 2017 at 10:55:28AM -0600, Mathieu Poirier wrote:
> On Mon, Jun 12, 2017 at 03:36:40PM +0100, Suzuki K Poulose wrote:
> > The Linux coresight drivers define the programmable ATB replicator as
> > Qualcom replicator, while this is designed by ARM. This can cause confusion
> > to a user selecting the driver. Cleanup all references to make it
> >  explicitly clear. This patch :
> > 
> >  1) Adds a new compatible string for the same, retaining the old one for
> >     compatibility.
> >  2) Changes the Kconfig symbol (since this is not part of any defconfigs)
> > 	 CORESIGHT_QCOM_REPLICATOR => CORESIGHT_DYNAMIC_REPLICATOR
> >  3) Improves the help message in the Kconfig.
> >  4) Changes the name of the driver :
> > 	coresight-replicator-qcom => coresight-dynamic-replicator
> > 
> > Cc: Pratik Patel <pratikp@...eaurora.org>
> > Cc: Ivan T. Ivanov <ivan.ivanov@...aro.org>
> > Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> > Cc: devicetree@...r.kernel.org
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
> 
> Hi Suzuki,
> 
> > ---
> >  Documentation/devicetree/bindings/arm/coresight.txt     |  4 +++-
> >  drivers/hwtracing/coresight/Kconfig                     | 10 +++++-----
> >  drivers/hwtracing/coresight/Makefile                    |  2 +-
> >  drivers/hwtracing/coresight/coresight-replicator-qcom.c |  2 +-
> >  4 files changed, 10 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> > index fcbae6a..f77329f 100644
> > --- a/Documentation/devicetree/bindings/arm/coresight.txt
> > +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> > @@ -34,7 +34,9 @@ its hardware characteristcs.
> >  		- Embedded Trace Macrocell (version 4.x):
> >  			"arm,coresight-etm4x", "arm,primecell";
> >  
> > -		- Qualcomm Configurable Replicator (version 1.x):
> > +		- Coresight programmable Replicator (version 1.x):
> > +			"arm,coresight-dynamic-replicator", "arm,primecell";
> > +				OR
> >  			"qcom,coresight-replicator1x", "arm,primecell";
> 
> Rob, what's your view on keeping the old binding around?  We could simply change
> the two occurences we find in the DTs (Juno and 410c) to the new name and be
> done with the old one.

Juno uses the Qcom string? We should keep the old string. You can switch 
the dts files, but the driver should support the old name.

Acked-by: Rob Herring <robh@...nel.org>