linux-kernel - Re: [PATCH RESEND] i2c: add sc18is600 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd_eHdkXk23HFwOK_3ciZaSKZAFrPtYzKgnBpuGaCo2-g@mail.gmail.com>
Date:   Sun, 18 Jun 2017 17:17:27 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] i2c: add sc18is600 driver

On Sun, Jun 18, 2017 at 5:02 PM, Sebastian Reichel <sre@...nel.org> wrote:

> Thanks for your feedback.

You're welcome!

> On Sat, Jun 17, 2017 at 09:13:32PM +0300, Andy Shevchenko wrote:
>> On Tue, Jun 13, 2017 at 6:47 PM, Sebastian Reichel <sre@...nel.org> wrote:

>> > +       snprintf(dev->adapter.name, sizeof(dev->adapter.name),
>>
>> > +                "SC18IS600 at SPI %02d device %02d",
>>
>> Isn't too much for adapter name?
>> I don't remember if it's part of ABI, in that case it's even worse.
>
> Well, it's displayed by "i2cdetect -l". Here are the names from some
> other drivers, which I used as reference:
>
> i2c-tiny-usb at bus %03d device %03d
> i2c-diolan-u2c at bus %03d device %03d
> OSIF at bus %03d device %03d
> SMBus Via Pro adapter at %04x
> SMBus SIS5595 adapter at %04x

Ah, okay.

-- 
With Best Regards,
Andy Shevchenko