linux-kernel - Re: attempting to format brd device results in OOM kills

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e8cdef3-7062-0a11-63c1-e19fabcd117c@kernel.dk>
Date:   Sun, 18 Jun 2017 16:21:36 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Jeff Layton <jlayton@...hat.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     Hannes Reinecke <hare@...e.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: attempting to format brd device results in OOM kills

On 06/18/2017 10:30 AM, Jeff Layton wrote:
> I've run across a regression from v4.11. If I boot a v4.12-rc1 or later
> kernel, make a large brd device and try to format it, it quickly slows
> down to a crawl and then the OOM killer kicks in.
> 
> I ran a bisect and it landed here:
> 
> commit f09a06a193d942a12c1a33c153388b3962222006 (HEAD, refs/bisect/bad)
> Author: Christoph Hellwig <hch@....de>
> Date:   Wed Apr 5 19:21:16 2017 +0200
> 
>     brd: remove discard support
>     
>     It's just a in-driver reimplementation of writing zeroes to the pages,
>     which fails if the discards aren't page aligned.
>     
>     Signed-off-by: Christoph Hellwig <hch@....de>
>     Reviewed-by: Hannes Reinecke <hare@...e.com>
>     Signed-off-by: Jens Axboe <axboe@...com>
> 
> 
> I've been reproducing it in a VM with ~8G allocated to it:
> 
> I have a modprobe.d file with this in it:
> 
>     options brd rd_nr=1 rd_size=1073741824
> 
> I then just:
> 
>     # modprobe brd
>     # mkfs -t ext2 /dev/ram0
> 
> It keels over pretty quickly after that.

Just checked, and creating a 1TB ram disk and then running mkfs.ext2 on it
writes 16851MiB of data. I can't say I'm surprised you OOM, if you run that
in a 8G VM, as you're about 8G short.

I'm puzzled as to why the discard change would make any difference, however.

-- 
Jens Axboe