[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170618230210.GB3690@dtor-ws>
Date: Sun, 18 Jun 2017 16:02:10 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Benjamin Valentin <benpicco@...glemail.com>
Cc: Cameron Gutman <aicommander@...il.com>,
Pavel Rojtberg <rojtberg@...il.com>,
"Pierre-Loup A. Griffais" <eduke32@...gman.net>,
Daniel Tobias <dan.g.tob@...il.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 2/2] Input: xpad - sync supported devices with XBCD
On Fri, Jun 16, 2017 at 12:32:46AM +0200, Benjamin Valentin wrote:
> XBCD [0][1] is an OpenSource driver for Xbox controllers on Windows.
> Later it also started supporting Xbox360 controllers (presumably before
> the official Windows driver was released).
>
> It contains a couple device IDs unknown to the Linux driver, so I extracted
> those from xbcd.inf and added them to our list.
>
> It has a special type for Wheels and I have the feeling they might need some
> extra handling. They all have 'Wheel' in their name, so that information is
> availiable for future improvements.
>
> [0] https://www.s-config.com/xbcd-original-xbox-controllers-win10/
> [1] http://www.redcl0ud.com/xbcd.html
>
> Reviewed-by: Cameron Gutman <aicommander@...il.com>
> Signed-off-by: Benjamin Valentin <benpicco@...glemail.com>
Applied, thank you.
> ---
>
> drivers/input/joystick/xpad.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index b8d08f2296ff..298a6ba51411 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -126,7 +126,10 @@ static const struct xpad_device {
> u8 mapping;
> u8 xtype;
> } xpad_device[] = {
> + { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> + { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
> { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX },
> + { 0x044f, 0x0f10, "Thrustmaster Modena GT Wheel", 0, XTYPE_XBOX },
> { 0x044f, 0xb326, "Thrustmaster Gamepad GP XID", 0, XTYPE_XBOX360 },
> { 0x045e, 0x0202, "Microsoft X-Box pad v1 (US)", 0, XTYPE_XBOX },
> { 0x045e, 0x0285, "Microsoft X-Box pad (Japan)", 0, XTYPE_XBOX },
> @@ -147,16 +150,30 @@ static const struct xpad_device {
> { 0x046d, 0xc242, "Logitech Chillstream Controller", 0, XTYPE_XBOX360 },
> { 0x046d, 0xca84, "Logitech Xbox Cordless Controller", 0, XTYPE_XBOX },
> { 0x046d, 0xca88, "Logitech Compact Controller for Xbox", 0, XTYPE_XBOX },
> + { 0x046d, 0xca8a, "Logitech Precision Vibration Feedback Wheel", 0, XTYPE_XBOX },
> { 0x046d, 0xcaa3, "Logitech DriveFx Racing Wheel", 0, XTYPE_XBOX360 },
> { 0x056e, 0x2004, "Elecom JC-U3613M", 0, XTYPE_XBOX360 },
> { 0x05fd, 0x1007, "Mad Catz Controller (unverified)", 0, XTYPE_XBOX },
> { 0x05fd, 0x107a, "InterAct 'PowerPad Pro' X-Box pad (Germany)", 0, XTYPE_XBOX },
> + { 0x05fe, 0x3030, "Chic Controller", 0, XTYPE_XBOX },
> + { 0x05fe, 0x3031, "Chic Controller", 0, XTYPE_XBOX },
> + { 0x062a, 0x0020, "Logic3 Xbox GamePad", 0, XTYPE_XBOX },
> + { 0x062a, 0x0033, "Competition Pro Steering Wheel", 0, XTYPE_XBOX },
> + { 0x06a3, 0x0200, "Saitek Racing Wheel", 0, XTYPE_XBOX },
> + { 0x06a3, 0x0201, "Saitek Adrenalin", 0, XTYPE_XBOX },
> + { 0x06a3, 0xf51a, "Saitek P3600", 0, XTYPE_XBOX360 },
> + { 0x0738, 0x4506, "Mad Catz 4506 Wireless Controller", 0, XTYPE_XBOX },
> { 0x0738, 0x4516, "Mad Catz Control Pad", 0, XTYPE_XBOX },
> + { 0x0738, 0x4520, "Mad Catz Control Pad Pro", 0, XTYPE_XBOX },
> { 0x0738, 0x4522, "Mad Catz LumiCON", 0, XTYPE_XBOX },
> { 0x0738, 0x4526, "Mad Catz Control Pad Pro", 0, XTYPE_XBOX },
> + { 0x0738, 0x4530, "Mad Catz Universal MC2 Racing Wheel and Pedals", 0, XTYPE_XBOX },
> { 0x0738, 0x4536, "Mad Catz MicroCON", 0, XTYPE_XBOX },
> { 0x0738, 0x4540, "Mad Catz Beat Pad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> { 0x0738, 0x4556, "Mad Catz Lynx Wireless Controller", 0, XTYPE_XBOX },
> + { 0x0738, 0x4586, "Mad Catz MicroCon Wireless Controller", 0, XTYPE_XBOX },
> + { 0x0738, 0x4588, "Mad Catz Blaster", 0, XTYPE_XBOX },
> + { 0x0738, 0x45ff, "Mad Catz Beat Pad (w/ Handle)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> { 0x0738, 0x4716, "Mad Catz Wired Xbox 360 Controller", 0, XTYPE_XBOX360 },
> { 0x0738, 0x4718, "Mad Catz Street Fighter IV FightStick SE", 0, XTYPE_XBOX360 },
> { 0x0738, 0x4726, "Mad Catz Xbox 360 Controller", 0, XTYPE_XBOX360 },
> @@ -164,6 +181,7 @@ static const struct xpad_device {
> { 0x0738, 0x4736, "Mad Catz MicroCon Gamepad", 0, XTYPE_XBOX360 },
> { 0x0738, 0x4738, "Mad Catz Wired Xbox 360 Controller (SFIV)", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> { 0x0738, 0x4740, "Mad Catz Beat Pad", 0, XTYPE_XBOX360 },
> + { 0x0738, 0x4743, "Mad Catz Beat Pad Pro", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> { 0x0738, 0x4758, "Mad Catz Arcade Game Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> { 0x0738, 0x4a01, "Mad Catz FightStick TE 2", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
> { 0x0738, 0x6040, "Mad Catz Beat Pad Pro", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> @@ -175,6 +193,9 @@ static const struct xpad_device {
> { 0x0738, 0xcb03, "Saitek P3200 Rumble Pad - PC/Xbox 360", 0, XTYPE_XBOX360 },
> { 0x0738, 0xcb29, "Saitek Aviator Stick AV8R02", 0, XTYPE_XBOX360 },
> { 0x0738, 0xf738, "Super SFIV FightStick TE S", 0, XTYPE_XBOX360 },
> + { 0x07ff, 0xffff, "Mad Catz GamePad", 0, XTYPE_XBOX360 },
> + { 0x0c12, 0x0005, "Intec wireless", 0, XTYPE_XBOX },
> + { 0x0c12, 0x8801, "Nyko Xbox Controller", 0, XTYPE_XBOX },
> { 0x0c12, 0x8802, "Zeroplus Xbox Controller", 0, XTYPE_XBOX },
> { 0x0c12, 0x8809, "RedOctane Xbox Dance Pad", DANCEPAD_MAP_CONFIG, XTYPE_XBOX },
> { 0x0c12, 0x880a, "Pelican Eclipse PL-2023", 0, XTYPE_XBOX },
> @@ -182,10 +203,13 @@ static const struct xpad_device {
> { 0x0c12, 0x9902, "HAMA VibraX - *FAULTY HARDWARE*", 0, XTYPE_XBOX },
> { 0x0d2f, 0x0002, "Andamiro Pump It Up pad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> { 0x0e4c, 0x1097, "Radica Gamester Controller", 0, XTYPE_XBOX },
> + { 0x0e4c, 0x1103, "Radica Gamester Reflex", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX },
> { 0x0e4c, 0x2390, "Radica Games Jtech Controller", 0, XTYPE_XBOX },
> + { 0x0e4c, 0x3510, "Radica Gamester", 0, XTYPE_XBOX },
> { 0x0e6f, 0x0003, "Logic3 Freebird wireless Controller", 0, XTYPE_XBOX },
> { 0x0e6f, 0x0005, "Eclipse wireless Controller", 0, XTYPE_XBOX },
> { 0x0e6f, 0x0006, "Edge wireless Controller", 0, XTYPE_XBOX },
> + { 0x0e6f, 0x0008, "After Glow Pro Controller", 0, XTYPE_XBOX },
> { 0x0e6f, 0x0105, "HSM3 Xbox360 dancepad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX360 },
> { 0x0e6f, 0x0113, "Afterglow AX.1 Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
> { 0x0e6f, 0x011f, "Rock Candy Gamepad Wired Controller", 0, XTYPE_XBOX360 },
> @@ -221,6 +245,7 @@ static const struct xpad_device {
> { 0x0f0d, 0x0063, "Hori Real Arcade Pro Hayabusa (USA) Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
> { 0x0f0d, 0x0067, "HORIPAD ONE", 0, XTYPE_XBOXONE },
> { 0x0f0d, 0x0078, "Hori Real Arcade Pro V Kai Xbox One", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
> + { 0x0f30, 0x010b, "Philips Recoil", 0, XTYPE_XBOX },
> { 0x0f30, 0x0202, "Joytech Advanced Controller", 0, XTYPE_XBOX },
> { 0x0f30, 0x8888, "BigBen XBMiniPad Controller", 0, XTYPE_XBOX },
> { 0x102c, 0xff0c, "Joytech Wireless Advanced Controller", 0, XTYPE_XBOX },
> @@ -255,6 +280,8 @@ static const struct xpad_device {
> { 0x1bad, 0xf027, "Mad Catz FPS Pro", 0, XTYPE_XBOX360 },
> { 0x1bad, 0xf028, "Street Fighter IV FightPad", 0, XTYPE_XBOX360 },
> { 0x1bad, 0xf02e, "Mad Catz Fightpad", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> + { 0x1bad, 0xf030, "Mad Catz Xbox 360 MC2 MicroCon Racing Wheel", 0, XTYPE_XBOX360 },
> + { 0x1bad, 0xf036, "Mad Catz MicroCon GamePad Pro", 0, XTYPE_XBOX360 },
> { 0x1bad, 0xf038, "Street Fighter IV FightStick TE", 0, XTYPE_XBOX360 },
> { 0x1bad, 0xf039, "Mad Catz MvC2 TE", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> { 0x1bad, 0xf03a, "Mad Catz SFxT Fightstick Pro", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX360 },
> @@ -300,6 +327,7 @@ static const struct xpad_device {
> { 0x24c6, 0x5b03, "Thrustmaster Ferrari 458 Racing Wheel", 0, XTYPE_XBOX360 },
> { 0x24c6, 0x5d04, "Razer Sabertooth", 0, XTYPE_XBOX360 },
> { 0x24c6, 0xfafe, "Rock Candy Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
> + { 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
> { 0xffff, 0xffff, "Chinese-made Xbox Controller", 0, XTYPE_XBOX },
> { 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
> };
> @@ -387,9 +415,11 @@ static struct usb_device_id xpad_table[] = {
> XPAD_XBOXONE_VENDOR(0x045e), /* Microsoft X-Box One controllers */
> XPAD_XBOX360_VENDOR(0x046d), /* Logitech X-Box 360 style controllers */
> XPAD_XBOX360_VENDOR(0x056e), /* Elecom JC-U3613M */
> + XPAD_XBOX360_VENDOR(0x06a3), /* Saitek P3600 */
> XPAD_XBOX360_VENDOR(0x0738), /* Mad Catz X-Box 360 controllers */
> { USB_DEVICE(0x0738, 0x4540) }, /* Mad Catz Beat Pad */
> XPAD_XBOXONE_VENDOR(0x0738), /* Mad Catz FightStick TE 2 */
> + XPAD_XBOX360_VENDOR(0x07ff), /* Mad Catz GamePad */
> XPAD_XBOX360_VENDOR(0x0e6f), /* 0x0e6f X-Box 360 controllers */
> XPAD_XBOXONE_VENDOR(0x0e6f), /* 0x0e6f X-Box One controllers */
> XPAD_XBOX360_VENDOR(0x0f0d), /* Hori Controllers */
> --
> 2.11.0
--
Dmitry
Powered by blists - more mailing lists