linux-kernel - Re: [PATCH v2] spi/bcm63xx: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1497901338.8495.50.camel@perches.com>
Date:   Mon, 19 Jun 2017 12:42:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Aravind Thokala <aravind.thk@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi/bcm63xx: Fix checkpatch warnings

On Mon, 2017-06-19 at 23:47 +0530, Aravind Thokala wrote:
> This patch fixes the checkpatch.pl warnings on the driver
> file.
[]
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
[]
> @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
>  #endif
>  }
>  
> -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
> +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
>  	{ 20000000, SPI_CLK_20MHZ },
>  	{ 12500000, SPI_CLK_12_50MHZ },
>  	{  6250000, SPI_CLK_6_250MHZ },

It's probably better to change this array into a struct
to make the indexing more obvious.

Also the SPI_CLK_MASK uses are a bit obscure.

Perhaps:
---
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index 247f71b02235..3cb8d92ee870 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -191,7 +191,10 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs,
 #endif
 }
 
-static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = {
+static const struct {
+	unsigned int speed;
+	unsigned int index;
+} bcm63xx_spi_freq_table[] = {
 	{ 20000000, SPI_CLK_20MHZ },
 	{ 12500000, SPI_CLK_12_50MHZ },
 	{  6250000, SPI_CLK_6_250MHZ },
@@ -213,8 +216,8 @@ static void bcm63xx_spi_setup_transfer(struct spi_device *spi,
 
 	/* Find the closest clock configuration */
 	for (i = 0; i < SPI_CLK_MASK; i++) {
-		if (t->speed_hz >= bcm63xx_spi_freq_table[i][0]) {
-			clk_cfg = bcm63xx_spi_freq_table[i][1];
+		if (t->speed_hz >= bcm63xx_spi_freq_table[i].speed) {
+			clk_cfg = bcm63xx_spi_freq_table[i].index;
 			break;
 		}
 	}