linux-kernel - Re: [patch v2] tty: define tty_open_by_driver when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170619212545.qswsepu3wbdv5dnh@var.youpi.perso.aquilenet.fr>
Date:   Mon, 19 Jun 2017 23:25:45 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Okash Khawaja <okash.khawaja@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        speakup@...ux-speakup.org, devel@...verdev.osuosl.org
Subject: Re: [patch v2] tty: define tty_open_by_driver when CONFIG_TTY is not
 defined

Okash Khawaja, on sam. 17 juin 2017 22:32:55 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows convention for other such
> functions and returns NULL.
> 
> Signed-off-by: Okash Khawaja <okash.khawaja@...il.com>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> 
> ---
>  include/linux/tty.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -422,6 +422,9 @@ static inline int __init tty_init(void)
>  { return 0; }
>  static inline const char *tty_name(const struct tty_struct *tty)
>  { return "(none)"; }
> +static inline struct tty_struct *tty_open_by_driver(dev_t device,
> +		struct inode *inode, struct file *filp)
> +{ return NULL; }
>  #endif
>  
>  extern struct ktermios tty_std_termios;
> 

-- 
Samuel
<O> Ça peut être une madeleine à sous munitions (avec des composants,
par exemple)
 -+- #runtime -+-