linux-kernel - Re: [PATCH 3/3] rtc: st-lpc: make it robust against y2038/2106 bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba0475d6-b386-9bb9-0b3b-5a4568633e62@st.com>
Date:   Mon, 19 Jun 2017 07:57:48 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "sboyd@...eaurora.org" <sboyd@...eaurora.org>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...e-electrons.com" 
        <alexandre.belloni@...e-electrons.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>
CC:     "linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>
Subject: Re: [PATCH 3/3] rtc: st-lpc: make it robust against y2038/2106 bug

Hi Benjamin

On 06/16/2017 04:03 PM, Benjamin Gaignard wrote:
> Make driver use u64 variables and functions to be sure that
> it will support dates after year 2038.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> ---
>   drivers/rtc/rtc-st-lpc.c | 19 ++++++++-----------
>   1 file changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-st-lpc.c b/drivers/rtc/rtc-st-lpc.c
> index 74c0a33..82b0af1 100644
> --- a/drivers/rtc/rtc-st-lpc.c
> +++ b/drivers/rtc/rtc-st-lpc.c
> @@ -99,7 +99,7 @@ static int st_rtc_read_time(struct device *dev, struct rtc_time *tm)
>   
>   	lpt = ((unsigned long long)lpt_msb << 32) | lpt_lsb;
>   	do_div(lpt, rtc->clkrate);
> -	rtc_time_to_tm(lpt, tm);
> +	rtc_time64_to_tm(lpt, tm);
>   
>   	return 0;
>   }
> @@ -107,13 +107,10 @@ static int st_rtc_read_time(struct device *dev, struct rtc_time *tm)
>   static int st_rtc_set_time(struct device *dev, struct rtc_time *tm)
>   {
>   	struct st_rtc *rtc = dev_get_drvdata(dev);
> -	unsigned long long lpt;
> -	unsigned long secs, flags;
> -	int ret;
> +	unsigned long long lpt, secs;
> +	unsigned long flags;
>   
> -	ret = rtc_tm_to_time(tm, &secs);
> -	if (ret)
> -		return ret;
> +	secs = rtc_tm_to_time64(tm);
>   
>   	lpt = (unsigned long long)secs * rtc->clkrate;
>   
> @@ -161,13 +158,13 @@ static int st_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *t)
>   {
>   	struct st_rtc *rtc = dev_get_drvdata(dev);
>   	struct rtc_time now;
> -	unsigned long now_secs;
> -	unsigned long alarm_secs;
> +	unsigned long long now_secs;
> +	unsigned long long alarm_secs;
>   	unsigned long long lpa;
>   
>   	st_rtc_read_time(dev, &now);
> -	rtc_tm_to_time(&now, &now_secs);
> -	rtc_tm_to_time(&t->time, &alarm_secs);
> +	now_secs = rtc_tm_to_time64(&now);
> +	alarm_secs = rtc_tm_to_time64(&t->time);
>   
>   	/* Invalid alarm time */
>   	if (now_secs > alarm_secs)
> 

Acked-by: Patrice Chotard <patrice.chotard@...com>

Thanks