linux-kernel - Re: [PATCH V3] staging: vt6655

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170619093507.xnuosshoiyejkgow@mwanda>
Date:   Mon, 19 Jun 2017 12:35:08 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Derek Robson <robsonde@...il.com>
Cc:     forest@...ttletooquiet.net, gregkh@...uxfoundation.org,
        rvarsha016@...il.com, sucha.cpe@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] staging: vt6655 - style fix

On Sat, Jun 17, 2017 at 02:56:48PM +1200, Derek Robson wrote:
> Fix checkpatch.pl warnings of the form "function definition argument
> 'foo' should also have an identifier name" in header files.
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>
> 
> V1 and V2 had vague subject line
> ---

The subject is *still* too vague.  Say something like:

[PATCH v4] Staging: vt6655 - add parameter names

Also the "V1 and V2 had vague subject line" has to go after the ---
line instead of before it.