linux-kernel - Re: [PATCH] drm: exynos: hdmi: make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Jun 2017 12:11:23 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, inki.dae@...sung.com,
        jy0922.shim@...sung.com, sw0312.kim@...sung.com,
        kyungmin.park@...sung.com, airlied@...ux.ie, krzk@...nel.org,
        javier@....samsung.com
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: exynos: hdmi: make of_device_ids const.

On 19.06.2017 11:24, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12294	   1192	      0	  13486	   34ae	drivers/gpu/drm/exynos/exynos_hdmi.o
>
> File size after constify hdmi_match_types.
>    text	   data	    bss	    dec	    hex	filename
>   13318	    176	      0	  13494	   34b6	drivers/gpu/drm/exynos/exynos_hdmi.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej

> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 1ff6ab6..624c48d 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1683,7 +1683,7 @@ static int hdmi_resources_init(struct hdmi_context *hdata)
>  	return hdmi_bridge_init(hdata);
>  }
>  
> -static struct of_device_id hdmi_match_types[] = {
> +static const struct of_device_id hdmi_match_types[] = {
>  	{
>  		.compatible = "samsung,exynos4210-hdmi",
>  		.data = &exynos4210_hdmi_driver_data,