linux-kernel - Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid intel_dsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFo9x8J=gbeVsbRNhNUd48htrjtgV8NEmv83BLDVmMN1Lg@mail.gmail.com>
Date:   Mon, 19 Jun 2017 13:01:38 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Christoph Hellwig <hch@....de>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][mmc-next][RESEND] mmc: sdhci-pci: make guid
 intel_dsm_guid static

On 19 June 2017 at 12:55, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>

Both me and Adrian have acked this, so it's fine to pick up by Christoph.

Kind regards
Uffe

>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/mmc/host/sdhci-pci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
>         bool    d3_retune;
>  };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
>         GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
>                   0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
> --
> 2.11.0
>