linux-kernel - Re: [PATCH v2 12/12] ASoC: Fix use-after-free at card unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87injstckf.fsf@belgarion.home>
Date:   Mon, 19 Jun 2017 13:57:20 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Haojian Zhuang" <haojian.zhuang@...il.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Lee Jones" <lee.jones@...aro.org>,
        "Lars-Peter Clausen" <lars@...afoo.de>,
        "Charles Keepax" <ckeepax@...nsource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Daniel Mack" <daniel@...que.org>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH v2 12/12] ASoC: Fix use-after-free at card unregistration

Takashi Iwai <tiwai@...e.de> writes:

> On Mon, 19 Jun 2017 09:27:09 +0200,
> Robert Jarzmik wrote:
>> 
>> From: Takashi Iwai <tiwai@...e.de>
>> 
>> soc_cleanup_card_resources() call snd_card_free() at the last of its
>> procedure.  This turned out to lead to a use-after-free.
>> PCM runtimes have been already removed via soc_remove_pcm_runtimes(),
>> while it's dereferenced later in soc_pcm_free() called via
>> snd_card_free().
>> 
>> The fix is simple: just move the snd_card_free() call to the beginning
>> of the whole procedure.  This also gives another benefit: it
>> guarantees that all operations have been shut down before actually
>> releasing the resources, which was racy until now.
>> 
>> Reported-and-tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Takashi Iwai <tiwai@...e.de>
>
> This patch must be superfluous :)
Haha :)

My serie shifted by one, so the very first of the serie is therefore missing,
formerly "ALSA: ac97: split out the generic ac97 registers" in
https://patchwork.kernel.org/patch/9398143/, and the shift triggered the
inclusion of the last patch of my tree, ie. yours :)

Cheers.

--
Robert