linux-kernel - Re: [PATCH 2/2] selftests: lib: prime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <149788031144.14237.2576196706318669393@mail.alporthouse.com>
Date:   Mon, 19 Jun 2017 14:51:51 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Sumit Semwal <sumit.semwal@...aro.org>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org
Cc:     lukas@...ner.de, linux-kernel@...r.kernel.org,
        daniel.vetter@...ll.ch, joonas.lahtinen@...ux.intel.com,
        "Sumit Semwal" <sumit.semwal@...aro.org>
Subject: Re: [PATCH 2/2] selftests: lib: prime_numbers: update presence check

Quoting Sumit Semwal (2017-06-19 14:44:32)
> The test for prime numbers doesn't differentiate between missing
> prime_numbers.ko and failure in prime_numbers.ko.
> 
> Update it to check for presence of the file itself to skip, therefore
> correctly exercising the test failure case.

modprobe -r shouldn't be executing the module? But you still need to
unload the module before you can load it with the selftest module
parameters. If you can't unload the module due to an earlier failure,
you cannot discern whether or not the module itself is at fault, so
still want to SKIP.
-Chris