linux-kernel - [PATCH] mm: remove a redundant condition in the for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170619135418.8580-1-haolee.swjtu@gmail.com>
Date:   Mon, 19 Jun 2017 21:54:18 +0800
From:   Hao Lee <haolee.swjtu@...il.com>
To:     akpm@...ux-foundation.org
Cc:     vbabka@...e.cz, mgorman@...hsingularity.net, mhocko@...e.com,
        hannes@...xchg.org, iamjoonsoo.kim@....com, minchan@...nel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Hao Lee <haolee.swjtu@...il.com>
Subject: [PATCH] mm: remove a redundant condition in the for loop

The variable current_order decreases from MAX_ORDER-1 to order, so the
condition current_order <= MAX_ORDER-1 is always true.

Signed-off-by: Hao Lee <haolee.swjtu@...il.com>
---
 mm/page_alloc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2302f25..9120c2b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2215,9 +2215,8 @@ __rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype)
 	bool can_steal;
 
 	/* Find the largest possible block of pages in the other list */
-	for (current_order = MAX_ORDER-1;
-				current_order >= order && current_order <= MAX_ORDER-1;
-				--current_order) {
+	for (current_order = MAX_ORDER-1; current_order >= order;
+							--current_order) {
 		area = &(zone->free_area[current_order]);
 		fallback_mt = find_suitable_fallback(area, current_order,
 				start_migratetype, false, &can_steal);
-- 
2.9.3