linux-kernel - RE: [PATCH V2] staging: unisys: visorhba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR07MB3176E806363185B742FC40BCF0C40@CY4PR07MB3176.namprd07.prod.outlook.com>
Date:   Mon, 19 Jun 2017 15:28:19 +0000
From:   "Kershner, David A" <David.Kershner@...sys.com>
To:     Derek Robson <robsonde@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Sell, Timothy C" <Timothy.Sell@...sys.com>,
        "Binder, David Anthony" <David.Binder@...sys.com>,
        "Wadgaonkar, Sameer Laxmikant" <Sameer.Wadgaonkar@...sys.com>,
        "marcos.souza.org@...il.com" <marcos.souza.org@...il.com>
CC:     *S-Par-Maintainer <SParMaintainer@...sys.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2] staging: unisys: visorhba - style fix


> -----Original Message-----
> From: Derek Robson [mailto:robsonde@...il.com]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A <David.Kershner@...sys.com>;
> gregkh@...uxfoundation.org; Sell, Timothy C <Timothy.Sell@...sys.com>;
> Binder, David Anthony <David.Binder@...sys.com>; Wadgaonkar, Sameer
> Laxmikant <Sameer.Wadgaonkar@...sys.com>;
> marcos.souza.org@...il.com; robsonde@...il.com
> Cc: *S-Par-Maintainer <SParMaintainer@...sys.com>;
> devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
> 
> Fixed style of permissions to octal.
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@...il.com>

I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit. 


> 
> V1 has vauge subject
> ---
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
>  		goto err_scsi_remove_host;
>  	}
>  	devdata->debugfs_info =
> -		debugfs_create_file("info", S_IRUSR | S_IRGRP,
> +		debugfs_create_file("info", 0440,
>  				    devdata->debugfs_dir, devdata,
>  				    &info_debugfs_fops);
>  	if (!devdata->debugfs_info) {
> --
> 2.13.0