linux-kernel - Re: [PATCH 4.9 031/108] jump label: pass kbuild_cflags when checking for asm goto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170619152918.GC10396@glebfm.cloud.tilaa.com>
Date:   Mon, 19 Jun 2017 18:29:18 +0300
From:   Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        David Lin <dtwlin@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Michal Marek <mmarek@...e.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sasha Levin <alexander.levin@...izon.com>,
        "Anton V. Boyarshinov" <boyarsh@...linux.org>,
        "Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH 4.9 031/108] jump label: pass kbuild_cflags when checking
 for asm goto support

On Thu, Jun 15, 2017 at 07:52:37PM +0200, Greg Kroah-Hartman wrote:
> 4.9-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: David Lin <dtwlin@...gle.com>
> 
> 
> [ Upstream commit 35f860f9ba6aac56cc38e8b18916d833a83f1157 ]

This commit introduced a regression which was fixed in
7292ae3d5a18fb922be496e6bb687647193569b4.
Backport the fix too, please.

As long as there is no gcc-plugin support in 4.4, 35f860f9ba6a does not
break anything there, AFAICS.

> Some versions of ARM GCC compiler such as Android toolchain throws in a
> '-fpic' flag by default.  This causes the gcc-goto check script to fail
> although some config would have '-fno-pic' flag in the KBUILD_CFLAGS.
> 
> This patch passes the KBUILD_CFLAGS to the check script so that the
> script does not rely on the default config from different compilers.
> 
> Link: http://lkml.kernel.org/r/20170120234329.78868-1-dtwlin@google.com
> Signed-off-by: David Lin <dtwlin@...gle.com>
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> Cc: Michal Marek <mmarek@...e.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/Makefile
> +++ b/Makefile
> @@ -797,7 +797,7 @@ KBUILD_CFLAGS   += $(call cc-option,-Wer
>  KBUILD_ARFLAGS := $(call ar-option,D)
>  
>  # check for 'asm goto'
> -ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y)
> +ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC) $(KBUILD_CFLAGS)), y)
>  	KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO
>  	KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO
>  endif
> 

-- 
glebfm